rsm-hcd / AndcultureCode.Cli

and-cli command-line tool to manage the development of software applications
https://andculture.com
Apache License 2.0
14 stars 15 forks source link

Fixed reference error in dotnet command from sorting imports in dotnet-cli module #68

Closed brandongregoryscott closed 4 years ago

brandongregoryscott commented 4 years ago

When I was going back to refactor out all instances of the previous /****..Region..*/ block, I must have sorted imports for the dotnet-cli module and not rerun the dotnet command. Due to the import destructuring of two functions in the formatters module coming before the formatters import itself, there was a reference error at runtime:

(node:44624) UnhandledPromiseRejectionWarning: ReferenceError: formatters is not defined at Object.<anonymous> (/Users/Brandon/AndcultureCode.Cli/_modules/dotnet-cli.js:5:32) at Module._compile (module.js:653:30) at Object.Module._extensions..js (module.js:664:10) at Module.load (module.js:566:32) at tryModuleLoad (module.js:506:12) at Function.Module._load (module.js:498:3) at Module.require (module.js:597:17) at require (internal/module.js:11:18) at require.run (/Users/Brandon/AndcultureCode.Cli/cli-dotnet.js:12:27) at Object.module.exports.run (/Users/Brandon/AndcultureCode.Cli/command-runner.js:10:11)

I separated them out so that it doesn't happen again.

codecov[bot] commented 4 years ago

Codecov Report

Merging #68 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   69.34%   69.34%           
=======================================
  Files          13       13           
  Lines         398      398           
  Branches       66       66           
=======================================
  Hits          276      276           
  Misses        101      101           
  Partials       21       21           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update beb1fdd...563e73b. Read the comment docs.