rsm-hcd / AndcultureCode.JavaScript.React.Components

Common atomically designed react components used at andculture

6 stars 8 forks source link

#38: Fixed issue with select arrow displaying beneath select dropdown. #46

Closed ralphmcintyre closed 4 years ago

ralphmcintyre commented 4 years ago

Fixes #38

[x] Related GitHub issue(s) linked in PR description
[x] Destination branch merged, built and tested with your changes
[x] Code formatted and follows best practices and patterns
[x] Code builds cleanly (no additional warnings or errors)
[x] Manually tested
[x] Automated tests are passing
[x] No decreases in automated test coverage
[-] Documentation updated (readme, docs, comments, etc.)
[-] Localization: No hard-coded error messages in code files (minimally in string constants)
[-] New component and/ or properties? Make sure to update storybook

codecov[bot] commented 4 years ago

Codecov Report

Merging #46 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   18.65%   18.65%           
=======================================
  Files          51       51           
  Lines         895      895           
  Branches      208      208           
=======================================
  Hits          167      167           
  Misses        718      718           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7a21c2c...4db2572. Read the comment docs.

brandongregoryscott commented 4 years ago

Looks good to me 👍 Thanks for fixing this up, @ralphjmcintyre!

brandongregoryscott commented 3 years ago

@all-contributors add @ralphjmcintyre for code

allcontributors[bot] commented 3 years ago

@brandongregoryscott

I've put up a pull request to add @ralphjmcintyre! :tada: