rsm-hcd / AndcultureCode.JavaScript.React.Components

Common atomically designed react components used at andculture
6 stars 8 forks source link

Rethink `InputCharacterCount` component #97

Open alexgetty opened 3 years ago

alexgetty commented 3 years ago

I think this component should be renamed as Fraction or something else more general so that it can be leveraged in other places (and potentially have some specific styling for a fraction representation. Either that or we totally remove this component and just add the character limit markup as part of the form fields that use it. Right now, this component is named too specifically to have multiple uses, and if an Atom only exists as part of a single Molecule, it shouldn't really be its own component.

I think renaming it would be better since then it can be used in other cases. Thoughts?