rsm-hcd / AndcultureCode.JavaScript.React

Common patterns, functions, etc... used when building react applications
6 stars 8 forks source link

Refactor into Core package - Enums, interfaces, records, utilities #2

Closed brandongregoryscott closed 4 years ago

brandongregoryscott commented 4 years ago

The following interfaces, records, and their associated tests should be pulled into the AndcultureCode.JavaScript.Core package, since they are not React-specific data structures or concepts.

enumerations/error-type.ts interfaces/paged-result.ts interfaces/result-error.ts interfaces/result.ts interfaces/service-response.ts view-models/result-error-record.ts view-models/result-record.ts

Be sure to revisit tests and ensure there is reasonable test coverage where it makes sense.

If it makes sense or is necessary, pull these utility classes into the core package as well: utilities/collection-utils.ts utilities/core-utils.ts

brandongregoryscott commented 4 years ago

@wintondeshong Feel free to add additional files that should be ported over into Core. I'm not sure how many non-React projects we have/will have in the near future, but I could see services/service-factory.ts being ported over as well since there is no dependency on React there.

wintondeshong commented 4 years ago

Going to be tackling this today

wintondeshong commented 4 years ago

Published in version v0.0.2