Open DudaGod opened 5 years ago
Apologies for the very late response. The ignore antialiasing mode is more tolerant of colour difference, in this case though I agree that it's a little too tolerant.
https://github.com/rsmbl/Resemble.js/blob/master/resemble.js#L879
It think its fair to say it should only use the increased tolerance mode on pixels identified as "anti-aliased" rather than all pixels. Any change in behaviour in this regard would probably require a major release.
Hey, is this issue still relevant? and if so can I work on it? 🧐
@rodrigo-garcia-leon Of course, although it may take me a while to review any changes.
Excellent 👌
Hi @jamescryer,
I've been reading the code to understand the issue and come up with possible solutions. I have three ideas in mind:
options
objectAdditionally, there's the improvement that you mentioned; use the increased tolerance mode only on pixels identified as "anti-aliased".
Not sure how to proceed, what do you think?
Hi @rodrigo-garcia-leon, It's offtopic for this specific bug, however option 3 mentioned will be very useful feature. Please let me know if I should open separate issue in order to implement it
Is this still an issue, im having a similar problem when I have enabled ignore antialiasing, it seems to be somewhat working but it is highlighting some areas in grey instead of the specified color
Diffrence only mode
Ignore less disabled
Hello guys.
How do you think these images are equivalent if you want to ignore antialiasing?
Expected behaviour: comparison with tolerance 2.3 and with ignore antialiasing