rsmelo92 / portfolio-old

Access
https://rsmelo92.github.io/portfolio/
3 stars 0 forks source link

Sweep: Add Timeline translation to english #34

Closed rsmelo92 closed 1 year ago

sweep-ai[bot] commented 1 year ago

Here's the PR! https://github.com/rsmelo92/portfolio/pull/36.

⚡ Sweep Free Trial: I used GPT-4 to create this ticket. You have 5 GPT-4 tickets left. For more GPT-4 tickets, visit our payment portal.To get Sweep to recreate this ticket, leave a comment prefixed with "sweep:" or edit the issue.


Step 1: 🔍 Code Search

Working on it...


Step 2: 🧐 Snippet Analysis

From looking through the relevant snippets, I decided to make the following modifications:

File Path Proposed Changes
src/components/Timeline/Timeline.js Replace all hardcoded Portuguese text with references to a translations object. This object should be loaded from the appropriate translations file based on the user's language preference. For example, replace "Portfólio" with translations.portfolio, "Todos os trabalhos abaixo tiveram o back-end e front-end feitos por mim, a menos que indicado o contrário" with translations.description, and so on for all the text in the component.
src/components/Timeline/translations_en.json Create this file and add English translations for all the text currently in the Timeline component. The keys should match the references added to the Timeline component, and the values should be the English translations. For example, "portfolio": "Portfolio", "description": "All the works below had the back-end and front-end done by me, unless otherwise indicated", and so on for all the text.

Step 3: 📝 Planning

I have created a plan for writing the pull request. I am now working my plan and coding the required changes to address this issue. Here is the planned pull request:

Add Timeline translation to English sweep/add-timeline-translation

Description

This PR adds support for English translations in the Timeline component of the portfolio. Currently, the component has hardcoded Portuguese text, which is not ideal for internationalization. To address this, the PR introduces a simple i18n system that externalizes the text into a separate translations file. The Timeline component is modified to load the appropriate translations based on the user's language preference.

Summary of Changes

  • Created a new translations file translations_en.json in the src/components/Timeline directory.
  • Added English translations for all the text currently in the Timeline component.
  • Modified the Timeline component to load the appropriate translations based on the user's language preference.
  • Replaced all hardcoded Portuguese text with references to the translations object in the Timeline component.

This PR provides a foundation for adding more languages in the future and improves the internationalization support of the portfolio.


Step 4: ⌨️ Coding

I have finished coding the issue. I am now reviewing it for completeness.


Step 5: 🔁 Code Review

Success! 🚀


To recreate the pull request, leave a comment prefixed with "sweep:" or edit the issue. Join Our Discord