search

rsmmr / hilti

**NOTE**: This is outdated and no longer maintained. There's a new version at https://github.com/zeek/spicy.
Other
40 stars 22 forks source link

Update bytes.c #6

Closed emmekappa86 closed 9 years ago

rsmmr commented 9 years ago

I've merged it into my branch but I don't think it's working quite right yet. I added a test for the underlying HILTI instruction to tests/hilti/bytes/to-int-binary.hlt. That works for a single-byte sequence, but not for a longer one: b"\xff\xff\xff\xd6" turns into 0xffffffff00000029.

emmekappa86 commented 9 years ago

I am checking right away

2015-07-10 7:42 GMT-07:00 Robin Sommer notifications@github.com:

Merged #6 https://github.com/rsmmr/hilti/pull/6.

— Reply to this email directly or view it on GitHub https://github.com/rsmmr/hilti/pull/6#event-352994907.

emmekappa86 commented 9 years ago

There was an int overflow. Now it is fixed. However, I think the "to_uint" hilti method does not work properly.

2015-07-10 9:48 GMT-07:00 Marco Caselli marcocaselli86@gmail.com:

I am checking right away

2015-07-10 7:42 GMT-07:00 Robin Sommer notifications@github.com:

Merged #6 https://github.com/rsmmr/hilti/pull/6.

— Reply to this email directly or view it on GitHub https://github.com/rsmmr/hilti/pull/6#event-352994907.