rsmp-nordic / rsmp_validator

Official RSMP Nordic automated test tool, build with Ruby and Rpec.
https://rsmp-nordic.github.io/rsmp_validator/
MIT License
4 stars 1 forks source link

ITC-3 uses wrong cases for alarm sS suspended enum on core 3.2.0 #427

Closed emiltin closed 3 weeks ago

emiltin commented 4 weeks ago

In Alarm messages like this, the sS attribute enum value should be "Suspended", not "suspended".

2024-09-06T11:24:15.457Z  52724  AA+BBCCC=DDD         AA+BBCCC=DDDDL002    78d7  Received invalid Alarm schema errors: /sS, enum,
{
    "mType": "rSMsg",
    "type": "Alarm",
    "mId": "78d79270-692e-4d7f-97bd-eaf97a9b1c6d",
    "ntsOId": "",
    "xNId": "",
    "cId": "AA+BBCCC=DDDDL002",
    "aCId": "A0302",
    "xACId": "Control Block 2: Det Logic 2 (<DET LOGIC NAME>) has an OFF failure.",
    "xNACId": "",
    "aSp": "Suspend",
    "ack": "notAcknowledged",
    "aS": "inActive",
    "sS": "suspended",
    "aTs": "2024-09-06T11:24:15.306Z",
    "cat": "D",
    "pri": "3",
    "rvs": []
}

Ref: https://rsmp-nordic.github.io/rsmp_core/3.2.2/applicability/basic_structure.html#alarm-status

emiltin commented 4 weeks ago

It's happening e.g. in this recent run, using core 3.2.0, tlc 1.0.15: https://github.com/rsmp-nordic/rsmp_validator/actions/runs/10738029422/job/29780761650

The latest passing tests was using core 3.1.5, tlc 1.0.15. The 3.2.0 core on the ITC-3 seems to have introduced this.

I plan to enable testing on all core version, as we now do for the gem tlc.

emiltin commented 4 weeks ago

@SwarcoPalm

sveitech commented 3 weeks ago

Issue has been fixed.

emiltin commented 3 weeks ago

Fix confirmed, closing.