search

rsmp-nordic / rsmp_validator

Official RSMP Nordic automated test tool, build with Ruby and Rpec.
https://rsmp-nordic.github.io/rsmp_validator/
MIT License
4 stars 1 forks source link

ITC-3 uses strings in aggregated status for core 3.1.2, should use booleans #432

Open emiltin opened 2 weeks ago

emiltin commented 2 weeks ago

When using core 3.1.2 the ITC-3 sends aggegrated status as strings, but it should use booleans.

    2024-09-09T10:27:36.513Z  47640  AA+BBCCC=DDD         -                    -     Connection to site AA+BBCCC=DDD established, using core 3.1.2, tlc 1.0.15

[...]

    2024-09-09T10:27:36.520Z  47640  AA+BBCCC=DDD         AA+BBCCC=DDDEEFFF    184a  Received invalid AggregatedStatus schema errors: /se/0, boolean, , /se/1, boolean, , /se/2, boolean, , /se/3, boolean, , /se/4, boolean, , /se/5, boolean, , /se/6, boolean, , /se/7, boolean,  {
    "mType": "rSMsg",
    "type": "AggregatedStatus",
    "mId": "184a7ad4-6248-4f4b-b646-7af560eb59be",
    "ntsOId": "AA+BBCCC=DDDEEFFF",
    "xNId": "",
    "cId": "AA+BBCCC=DDDEEFFF",
    "aSTS": "2024-09-09T10:27:36.489Z",
    "fP": "",
    "fS": "",
    "se": [
        "false",
        "false",
        "false",
        "false",
        "true",
        "true",
        "false",
        "false"
    ]
}

Test run: https://github.com/rsmp-nordic/rsmp_validator/actions/runs/10771259494/job/29866405946

Reference: https://rsmp-nordic.github.io/rsmp_core/3.2.1/applicability/basic_structure.html#aggregated-status-message

emiltin commented 1 week ago

@SwarcoPalm would you like ITC-3 testing for different core version to be activated on the testhub? Currently we're testing only 3.2.0.

SwarcoPalm commented 1 week ago

We support in general that the testhub/validator tests as broadly and as many permutations as possible. So testing different core versions in the future would be a very good addition I think.

SwarcoPalm commented 1 week ago

Also the reported issue is fixed :)

emiltin commented 1 week ago

OK thanks, testing of different core version is now being activated.

emiltin commented 1 week ago

Stil the case with 3.1.2:

    2024-09-11T13:03:27.065Z  35558  AA+BBCCC=DDD         -                    -     Connection to site AA+BBCCC=DDD established, using core 3.1.2, tlc 1.0.15

...

    2024-09-11T13:03:28.198Z  35560  AA+BBCCC=DDD         AA+BBCCC=DDDEEFFF    03b1  Received invalid AggregatedStatus schema errors: /se/0, boolean, , /se/1, boolean, , /se/2, boolean, , /se/3, boolean, , /se/4, boolean, , /se/5, boolean, , /se/6, boolean, , /se/7, boolean,  {
    "mType": "rSMsg",
    "type": "AggregatedStatus",
    "mId": "03b1b494-51ec-4f12-8a7f-824e3e8be147",
    "ntsOId": "AA+BBCCC=DDDEEFFF",
    "xNId": "",
    "cId": "AA+BBCCC=DDDEEFFF",
    "aSTS": "2024-09-11T13:03:28.164Z",
    "fP": "",
    "fS": "",
    "se": [
        "false",
        "false",
        "false",
        "false",
        "true",
        "true",
        "false",
        "false"
    ]
emiltin commented 1 week ago

It correctly uses booleans from 3.1.3