rsmp-nordic / rsmp_validator

Official RSMP Nordic automated test tool, build with Ruby and Rpec.
https://rsmp-nordic.github.io/rsmp_validator/
MIT License
4 stars 2 forks source link

ITC-3 uses incorrect timestamp for traffic counting #454

Open otterdahl opened 2 months ago

otterdahl commented 2 months ago

In recent runs, ITC-3 reports an incorrect time stamp 1970-01-01T00:00:00.000Z for start of traffic counting (S0201-S0208)

Example

    "sS": [
        {
            "sCI": "S0207",
            "n": "start",
            "q": "recent",
            "s": "1970-01-01T00:00:00.000Z"
        }
]
otterdahl commented 2 months ago

The validator doesn't catch this issue. Perhaps the test case can be extended

emiltin commented 2 months ago

The schema for S0207 should catch this, as the 'n' field in a sS 'start' element must be a standard rsmp timestamp: https://github.com/rsmp-nordic/rsmp_schema/blob/main/schemas/tlc/1.2.1/statuses/S0201.json#L51

But it seems this is not working for some reason.

SwarcoPalm commented 2 months ago

I think the timestamp format is valid enough, I'm guessing Davids suggestion is that this test controller indeed has not been counting since 1970?