search

rsms / fb-mac-messenger

⚡️ Mac app wrapping Facebook's Messenger for desktop
https://fbmacmessenger.rsms.me/
MIT License
2.86k stars 243 forks source link

Request to use San Francisco as typeface #372

Open chrismessina opened 7 years ago

chrismessina commented 7 years ago

I noticed that Messenger on the web (in Chrome Canary anyway) is now using San Francisco (right), rather than Helvetica (left), as the typeface.

Can the mac app be changed to reflect this?

fonts

stackptr commented 7 years ago

To my eyes, it seems like the app that I have (0.1.12.1487384288) and the latest version in master both use San Francisco, but it's kind of hard to tell:

screen shot 2017-03-25 at 5 23 08 pm

If there is an easy way to distinguish between the two fonts and the app is indeed using Helvetica, I can look into it further

chrismessina commented 7 years ago

Interesting. Messenger.com is using Helvetica, but if visit Messenger from Facebook.com (https://www.facebook.com/messages/t/messinabot) you'll see San Francisco.

messenger_and_3409f5ca-1180-11e7-8c46-23e53c3d4fd2_png__1996x1424_
rsms commented 7 years ago

I'm a huge fan of San Francisco, but I think it's going to be a lot less painful to simply wait for the messenger.com team to make this change. The Messenger for Mac app's user agent contains "like Safari/VERSION" in order for Facebook to deliver the correct JS (their server will sometimes deliver different code depending on the user agent) — point being that simply "spoofing" the user agent won't magically make the SF font appear (it might though), but will probably break some other parts of the app.

Alternatively we could inject CSS to override the font choices of messenger.com, but that is error prone (unless by some magical reason there's just a single level of font declaration in the stylesheets of messenger.com — someone feel free to investigate this :) )

chrismessina commented 7 years ago

Good points. Fair enough! On Wed, Apr 5, 2017 at 7:49 PM Rasmus notifications@github.com wrote:

I'm a huge fan of San Francisco, but I think it's going to be a lot less painful to simply wait for the messenger.com team to make this change. The Messenger for Mac app's user agent contains "like Safari/VERSION" in order for Facebook to deliver the correct JS (their server will sometimes deliver different code depending on the user agent) — point being that simply "spoofing" the user agent won't magically make the SF font appear (it might though), but will probably break some other parts of the app.

Alternatively we could inject CSS to override the font choices of messenger.com, but that is error prone (unless by some magical reason there's just a single level of font declaration in the stylesheets of messenger.com — someone feel free to investigate this :) )

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rsms/fb-mac-messenger/issues/372#issuecomment-292054327, or mute the thread https://github.com/notifications/unsubscribe-auth/AABYUvjT8_6VfQGf1A5Gz3BlPbazlAKVks5rtFKrgaJpZM4MmP8X .