Fix image (and other) pasting

rsms / fb-mac-messenger

⚡️ Mac app wrapping Facebook's Messenger for desktop

https://fbmacmessenger.rsms.me/

MIT License

2.86k stars 243 forks source link

Fix image (and other) pasting #411

Open greg opened 7 years ago

greg commented 7 years ago

The current paste implementation tries to override pasting image data with a fake drag event, which no longer works (requiring two attempts at a paste so it can paste the created URL normally the second time).

I've changed the logic so we mess around with the pasteboard data only when we have image data being pasted without a URL, and then everything gets passed straight through as a normal paste event with no further hackery.

Screenshots and other copied image data now paste on the first try (at 99% JPEG quality, which is much smaller than PNG and will get ruined by Facebook anyway), which resolves #393
Copied file(s) and image(s) paste correctly
Displays an error when trying to paste a directory
Remove unnecessary MMFakeDragInfo dependency

raxod502 commented 6 years ago

@rsms any update on this? I'd love to see this long-standing bug fixed.

sebastienrospars commented 6 years ago

I hope too @raxod502

raxod502 commented 6 years ago

@rsms Ping?

raxod502 commented 6 years ago

@rsms Is this project still maintained?

greg commented 6 years ago

Doesn't look like it... personally, I've gone back to using messenger.com now that it supports image paste in Safari (one of the main reasons I had for using this app).

The MIT license allows forking the project as long as the original author is left credited, so if someone feels like forking this and actively maintaining it, please go ahead and do that.

(while you're at it, I also have #345 and #410 hanging for over a year, so you might want to merge those in too 😛)

raxod502 commented 6 years ago

My use case was being able to jump unambiguously to Messenger with a global system hotkey. That would really be quite nice, but maybe I can learn to live without it. Alternatively, maybe https://messengerfordesktop.com/ works well enough to use instead.

greg commented 6 years ago

@raxod502 my issue with most messenger apps floating around (that one included, IIRC), was that they use Electron, which is a massive drain on RAM and battery, as opposed to this one which uses a plain WebView.