rsms / inter

The Inter font family
https://rsms.me/inter/
SIL Open Font License 1.1
17.92k stars 401 forks source link

Cyrillic її (two U+0457 CYRILLIC SMALL LETTER YI) #479

Closed ichik closed 2 years ago

ichik commented 2 years ago

Describe the bug ї stands too close to its neighbors, especially ones with diacritics, e.g. second ї (see attached screenshot).

Expected behavior A little bit more space / additional kerning would greatly help.

Screenshots

image
rsms commented 2 years ago

Please provide the following info: (it was in the issue template)

Environment

ichik commented 2 years ago

@rsms hey, thanks for following up on this. This (її sticking together too close) is reproducible on a variety of platforms for me: macOS 12.6 with Chrome, Firefox, and Safari, Windows 11 with Chrome and Firefox, Android 10 with Chrome and Firefox etc. fontdrop.info doesn't seem to support woff2, but the corresponding ttf from the same download is showing 3.019;git-0a5106e0b (It is 3.19 archive downloaded from rsms.me). I also checked and the same effect can be observed in Figma (not sure which version they have installed there) and in TextEdit when using locally installed font.

KrasnayaPloshchad commented 2 years ago

As my suggestion, this letter should firstly have contextual alternate to make diaeresis condensed, then you add just a little kerning between її, so you’ll make it more readable, and does not occupy more spacing. See also https://github.com/adobe-fonts/source-serif/issues/48.

rsms commented 2 years ago

Added an specialized "narrow" version of /idieresis that is used instead of the normal (wide) version when two yi or idieresis are next to each other:

idieresis.narrow

In case CCMP fails, there's also ample kerning:

fallback

rsms commented 2 years ago

Let me know if this looks good to y'all!

If the smooshed discs look too busy, we could add a ligature that uses three dots instead of four. Something like this:

three

kenmcd commented 2 years ago

This was also discussed in a Roboto-Flex issue. https://github.com/googlefonts/roboto-flex/issues/348 Because of that issue I kinda went on a quest to see how this is handled in other fonts. Found a number of fonts, including a couple fonts made by Ukrainian designers for two different Ukrainian organizations. Wanted to see how the Ukrainians would handle it themselves. Been meaning to summarize it all. Was going to do it today, and did work on it, but got distracted. Maybe finish it tomorrow.

Would like to review what has been done in a new beta when you get a chance.

rsms commented 2 years ago

@kenmcd That would be really interesting to learn about. You can grab the latest build here: https://github.com/rsms/inter/suites/8786622744/artifacts/399000934 (every push is built automatically and can be downloaded up to a day after the hit push. See the “Actions” tab in GitHub for an overview.)

ichik commented 2 years ago

I find the ligature quite pleasant. The four dots look fine in thinner weights, but start to look weird past the second line.

rsms commented 2 years ago

I made a "three dot" ligature this morning. Definitely reads better and if it's still recognized as two idieresis, I think this is the better solution.

ii2

Here's a build: Inter-4.00-e40c4c8940.zip

rsms commented 2 years ago

Now there's a ligature for capital letter with two dots as well (U+00CF and U+0407)

ii2cap

kenmcd commented 2 years ago

When I started investigating this I found quite a few fonts using the three dots. Such as Proba Pro, a commercial font, used on a number of Ukrainian websites including the Ukrainian Embassy in the US, the Ukrainian parliament, and the Ukrainian NATO sub-site. e-Ukraine, commissioned by and used on the website of The Ministry and the Committee for Digital Transformation of Ukraine - equally spaces the four dots, and also has a ligature with the right quote. The NAMU fonts, created for the National Art Museum of Ukraine (NAMU) - also uses the four equally spaced dots. There are other fonts with other ligatures, and there other collisions to deal with (parentheses , brackets, quotes, etc.). Some fonts use ccmp, some use liga, some use dlig, some use rlig, and some use calt. I like ccmp as it even works in Word (where calt is not On by default). Glad you are doing this. The last few months I have spent quite a bit of time in the Ukrainian military's Telegram groups, and other groups, on my android phone. So I have to look at the Roboto collisions all the time (quite annoying). I will take a look at the latest beta, and get back to getting this done.

sutnistj commented 2 years ago

Iʼm Ukrainian and I never saw or donʼt remember three dot ligature. And I may guess the reason: a combination ії is also often used.

rsms commented 2 years ago

I'll take this as the ligature being a good solution. Thank you all for your help!

rsms commented 2 years ago

Included in v4.0-beta6