rsmusllp / king-phisher

Phishing Campaign Toolkit
BSD 3-Clause "New" or "Revised" License
2.27k stars 540 forks source link

Sphinx new API #475

Closed g0tmi1k closed 2 years ago

g0tmi1k commented 3 years ago

Yes, the API was deprecated at 1.8.0. Please use app.add_css_file() instead.

REF: https://github.com/sphinx-doc/sphinx/issues/7747


Error:

dh build
   dh_update_autotools_config
   dh_autoreconf
   debian/rules override_dh_auto_build
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_auto_build
PYTHONPATH=. http_proxy='127.0.0.1:9' sphinx-build -N -bhtml docs/source build/html
Running Sphinx v4.2.0
loading translations [en]... done
making output directory... done

Exception occurred:
  File "/<<PKGBUILDDIR>>/docs/source/conf.py", line 85, in setup
    app.add_stylesheet('theme_overrides.css')
AttributeError: 'Sphinx' object has no attribute 'add_stylesheet'
The full traceback has been saved in /tmp/sphinx-err-6f06nq1h.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!
make[1]: *** [debian/rules:25: override_dh_auto_build] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:4: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
zeroSteiner commented 2 years ago

Well the King Phisher docs are supposed to be built with Sphinx 1.7.9, not Sphinx 1.8.x. So while that function has been deprecated, it shouldn't be a problem if the correct version is used. I tried updating Sphinx to 1.8.0, and building with this change caused some errors to come up. I also tried building with the current version of 1.7.9, and this change breaks the build.

Either everything needs to be updated, or nothing needs to be updated. This change on its own however would cause problems, particularly for the automatic docs build on readthedocs.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.