search

rsnitsch / py3createtorrent

Create torrents via command line!
Other
72 stars 7 forks source link

Linting workflow & Dependabot integration #17

Closed ToasterUwU closed 1 year ago

ToasterUwU commented 1 year ago

As promised in #13

ToasterUwU commented 1 year ago

@rsnitsch Have a look, and feel free to merge if you are ok with this.

I use this exact same thing in many of my Python projects, it helps a lot to minimize upkeep and also prevents many of the basic issues that can arise ( unbound vars, wrong types, etc. )

ToasterUwU commented 1 year ago

In case you arent familiar, everything used in here is free to use, so even tho this takes processing power, Github doesnt charge you for it.

ToasterUwU commented 1 year ago

Just realized i need to change it to use pipenv instead ( I don't use that )

rsnitsch commented 1 year ago

Very promising, thank you.

ToasterUwU commented 1 year ago

Ok, i have never used pipenv, i need to test it really quick on my fork, just to make sure it runs fine. After that you can merge it.

rsnitsch commented 1 year ago

Ok, i have never used pipenv, i need to test it really quick on my fork, just to make sure it runs fine. After that you can merge it.

Thank you for the extra diligence. 👌

ToasterUwU commented 1 year ago

@rsnitsch Take another look and merge if you want to. I tested this on my fork, and it worked. Meaning it screamed at me for the fact. I don't have the fixes from the #16 PR, but with them its smooth sailing.

ToasterUwU commented 1 year ago

If you wonder which to merge first, doesn't really matter.

The cleaner one would be to merge the other one first and then this one, but in the end of the day it will show "Lint Passed" as the newest status anyways.

The actual PR for #13 I will make either tomorrow or the day after, depending on what else is on my list tommorow.

rsnitsch commented 1 year ago

Thank you very much! I merge this first because I want to see it screaming. ;-)

ToasterUwU commented 1 year ago

@rsnitsch Btw, it might make sense to add all Python versions you want to officially support to the lint workflow. Just add them to the OS matrix thing next to 3.10 and 3.11. I recommend putting 3.8 in at least because that's pre-built-in type hinting.