search

rsnitsch / py3createtorrent

Create torrents via command line!
Other
72 stars 7 forks source link

Change rule of auto calculate piece size #7

Closed poonnawit closed 3 years ago

poonnawit commented 3 years ago

I suppose to change auto calculate piece size rule for flexible to download skip files by change piece size to: torrent size <16 KIB use 16 KIB of Piece size torrent size 16 KIB - 511 MIB : 256 KIB torrent size 512 MIB - 1023 MIB : 512 KIB torrent size 1024 MIB - 8 GIB : 1024 KIB torrent size 8 GIB - 16 GIB : 2048 KIB torrent size 16 GIB - 32 GIB : 4096 KIB torrent size 32 GIB - 64 GIB : 8192 KIB torrent size >64 GIB : 16384 KIB

rsnitsch commented 3 years ago

I don't understand what your contribution aims at. What does it attempt to improve?

poonnawit commented 3 years ago

Sorry I didn't more explain. I think the default rule of auto calculate piece size that uses too big piece size for the size of file around 8 - 32 GIB. e.g. For torrent size 9 GIB will use 8 MIB for piece size but I think it should use 2 MIB to keep low RAM usage with appropriate for the torrent size.

rsnitsch commented 3 years ago

On the other hand, smaller piece size leads to more network overhead, because the number of pieces for which availability information must be exchanged is bigger.

I think the current piece size calculation is fine.