search

rsnk96 / Ubuntu-Setup-Scripts

Scripts to help you set up your Ubuntu quickly, especially if you're in any subfield of Data Science or AI!
Apache License 2.0
126 stars 76 forks source link

Clear zsh installation directory if it already exists #45

Closed aswinkumar1999 closed 5 years ago

aswinkumar1999 commented 5 years ago

44

I have added a few lines to make sure the script deletes the appropriate folder to reinstall ZSH everytime you run the script.

rajat2004 commented 5 years ago

Thanks for the PR :-) Please have a look at the things I've pointed out

Also, after everything is fixed, could you squash the commits together into a single commit, it'll make it cleaner to merge. And make the commit message more meaningful, maybe something like remove zsh directory if already exists

rajat2004 commented 5 years ago

LGTM aside from the commit squashing. @aswinkumar1999 If you are unable to then let me know, I'll squash them and push it to your branch. Also another thing, just for future work on git, work on a branch rather than committing onto your master branch. This way you can test any bug-fixes or new features on a branch while keeping your master branch clean

aswinkumar1999 commented 5 years ago

@rajat2004 and @rsnk96 , I have squashed all three commits into one.

rajat2004 commented 5 years ago

Merged, thanks!!