Zim repo doesnt have Templates folder

rsnk96 / Ubuntu-Setup-Scripts

Scripts to help you set up your Ubuntu quickly, especially if you're in any subfield of Data Science or AI!

Apache License 2.0

128 stars 76 forks source link

Zim repo doesnt have Templates folder #59

Closed MukundVarmaT closed 4 years ago

MukundVarmaT commented 4 years ago

In 1-basicsetup.sh line 73 we copy the .zshrc .zlogin and .zimrc from the the templates folder in the repo https://github.com/zimfw/zimfw. However i dont find any such folder in the repo's master branch and is present in another branch called zsh-5.0 and zsh-5.2 and hence while running the script it errors out saying that ,zshrc does not exist when we echo some lines on to that file.

rajat2004 commented 4 years ago

Yes, noticed it this morning, when started a Travis build yesterday night. They did the first release of ZIM about 12 hours ago, with many backwards-incompatible changes. For now, switching to the older branches will work, have started looking into updating BasicSetup.sh

MukundVarmaT commented 4 years ago

So zim-5.2 is an older version? Yeah switching to another branch did work

rajat2004 commented 4 years ago

Merged https://github.com/rsnk96/Ubuntu-Setup-Scripts/pull/60 for a temporary fix