Build-OpenCV bug fixes - Githubissues

rsnk96 commented 4 years ago

Removed undo_rename of the renamed conda library files since QT doesn't work with it on
Removed renaming of
```
    rename_so libz.so
    rename_so libfreetype.so
    rename_so libharfbuzz.so
    rename_so libtbb.so
```
@rajat2004 did these libraries cause problems for you when you tried it out? It works on a fresh installation of Ubuntu Mate 18.04 with just the renaming of libfontconfig and libpangoft for me

rajat2004 commented 4 years ago

The problems were seen in the OpenCV + Conda Travis build for Ubuntu 16.04 and 18.04 I think a check should be added to test the OS version and rename libraries that are required, that PR had a lot of things, so this got missed. Not sure if the entire undo_rename should be removed, since things do work after undoing the rename.

rsnk96 commented 4 years ago

The problems were seen in the OpenCV + Conda Travis build for Ubuntu 16.04 and 18.04 I think a check should be added to test the OS version and rename libraries that are required, that PR had a lot of things, so this got missed.

Hopefully those errors aren't there now, the Travis build isn't showing anything. Do check if you feel the same.

Not sure if the entire undo_rename should be removed, since things do work after undoing the rename

Though cv2.getBuildInformation() works with undo_rename there, QT windows do not work in my tests. Ex: cv2.namedWindow() gives an error. Did you test QT windows coming up after the undo_rename()?

rajat2004 commented 4 years ago

Hopefully those errors aren't there now, the Travis build isn't showing anything. Do check if you feel the same.

The Travis build is showing the problems (Xenial) -

/opt/anaconda3/lib/libtbb.so.2: undefined reference to `__cxa_init_primary_exception@CXXABI_1.3.11'
/opt/anaconda3/lib/libtbb.so.2: undefined reference to `std::__exception_ptr::exception_ptr::exception_ptr(void*)@CXXABI_1.3.11'
collect2: error: ld returned 1 exit status
modules/xobjdetect/tools/waldboost_detector/CMakeFiles/opencv_waldboost_detector.dir/build.make:93: recipe for target 'bin/opencv_waldboost_detector' failed

Bionic build failed due to download error

Though cv2.getBuildInformation() works with undo_rename there, QT windows do not work in my tests. Ex: cv2.namedWindow() gives an error. Did you test QT windows coming up after the undo_rename()?

Wasn't able to, was testing in a docker container, and didn't do the X11 windows while starting the container. Was short on time, therefore looked for alternate ways and the ldd info seemed correct, also from info on the net Will do tests more thoroughly afterwards, sorry for this and thanks for fixing!

rajat2004 commented 4 years ago

Cancelled the Travis branch build since the PR build was queued

rajat2004 commented 4 years ago

@rsnk96 Noticed the target branch was not master, changed that but then the older commits which have already been merged came up, will need to drop the commits Would do it myself but don't want to mess up your commit history as well, had some bad experiences earlier with that

rsnk96 commented 4 years ago

No worries, do go ahead and fix it if you can!

rajat2004 commented 4 years ago

Seems okay to me, though I haven't done any further testing @rsnk96 ?

rsnk96 commented 4 years ago

Looks good to me, merging!

rsnk96 / Ubuntu-Setup-Scripts

Build-OpenCV bug fixes #69