rsnk96 / Ubuntu-Setup-Scripts

Scripts to help you set up your Ubuntu quickly, especially if you're in any subfield of Data Science or AI!
Apache License 2.0
128 stars 76 forks source link

Install latest Zsh+Zim #79

Closed rajat2004 closed 4 years ago

rajat2004 commented 4 years ago

Closes #59 https://github.com/zimfw/zimfw

TODO:

rsnk96 commented 4 years ago

Works on Ubuntu 18.04

rsnk96 commented 4 years ago

Update instructions for multiple users: probably just need to add

sudo cp ~/.zshenv /home/$NEW_USER/.zshenv

to the code block

rajat2004 commented 4 years ago

Works on Ubuntu 18.04

Great, thanks for testing!

Update instructions for multiple users: probably just need to add

sudo cp ~/.zshenv /home/$NEW_USER/.zshenv

to the code block

What about the .zimrc, .zshrc etc? Those would also need to be updated right? I haven't installed and checked this myself yet but, the templates are not there in the repo anymore, they're in the script itself, so I think those will also need to be copied from the orignal user's directory itself

rajat2004 commented 4 years ago

@rsnk96 Ah hell! I force-pushed the branch without fetching your commit for updating the Readme for the multiple users. If possible, could you add back your commit now, sorry for this!

rajat2004 commented 4 years ago

So the main points left to decide on-

  1. For source built zsh, should we stick to a specific version or the latest tag? (Only on Ubuntu 16.04, on 18.04, apt install)
  2. Disable zimfw from updating or not?

IMO latest tag should be good enough for source built, and disabling zimfw from checking updates doesn't seem to be a good thing, the user can decide whether or not to do it, though I don't have a strong preference for any choice

rsnk96 commented 4 years ago

IMO latest tag should be good enough for source built, and disabling zimfw from checking updates doesn't seem to be a good thing, the user can decide whether or not to do it, though I don't have a strong preference for any choice

I'm okay with both 👍

rajat2004 commented 4 years ago

@rsnk96 Great, thanks for the review! Merging