search

rsnodgrass / pyadtpulse

Python interface for ADT Pulse security systems
Other
15 stars 5 forks source link

Remove rlippmann/pyadtpulse and transfer #36

Open rsnodgrass opened 7 months ago

rsnodgrass commented 7 months ago

Hi @rlippmann, if you remove pyadtpulse completely from your repositories, I can transfer this over to you.

rlippmann commented 7 months ago

Hey Ryan,

The issue is more with hass-adtpulse. I put in a PR in HACS to make my repository the de-facto source, but the PR was rejected. They said that transferring required you to pass ownership of your repo over to me. I think it's dumb, but it kind of make sense. Also, since it took 3 months for the PR to be reviewed it might just be easier this way.

As for pyadtpulse, might be a while. Don't know if you've looked over my repo recently, but I've rewritten a lot of the code. I broke up the main objects into subobjects for maintainability/testing. I've also wrote a whole testing harness where I mock all the ADT calls. Needless to say, it was a big undertaking since I don't know pytest (and the tests are still probably not really true "unit" tests).

It's in the 1.2.0 branch if you want to take a peek.

rsnodgrass commented 7 months ago

Cool! I just started learning pytest too.

I can also transfer hass-pulse. Go ahead and remove it from your repos and I’ll transfer.

On Jan 25, 2024 at 8:55 AM, <rlippmann @.***)> wrote:

Hey Ryan,

The issue is more with hass-adtpulse. I put in a PR in HACS to make my repository the de-facto source, but the PR was rejected. They said that transferring required you to pass ownership of your repo over to me. I think it's dumb, but it kind of make sense. Also, since it took 3 months for the PR to be reviewed it might just be easier this way.

As for pyadtpulse, might be a while. Don't know if you've looked over my repo recently, but I've rewritten a lot of the code. I broke up the main objects into subobjects for maintainability/testing. I've also wrote a whole testing harness where I mock all the ADT calls. Needless to say, it was a big undertaking since I don't know pytest (and the tests are still probably not really true "unit" tests).

It's in the 1.2.0 branch if you want to take a peek.

— Reply to this email directly, view it on GitHub (https://github.com/rsnodgrass/pyadtpulse/issues/36#issuecomment-1910609978), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAQY4XFPAP6SUI5DALADEZ3YQKFBTAVCNFSM6AAAAABCK23SRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQGYYDSOJXHA). You are receiving this because you were assigned.Message ID: @.***>

rlippmann commented 7 months ago

Same problem. I'm working on 0.4 right now which so far just is changes required for 1.2.0, although I added a connection status sensor.

I've also been collaborating with Jacky Liang (the HomeBridge Pulse developer), and we might get rid of that whole fingerprint hack. I've reversed most of the flow for 2fa, and he's going to test my assumptions in HomeBridge first.

rlippmann commented 7 months ago

So, do I need to archive my repos? I don't think you can actually delete a repo.

rlippmann commented 7 months ago

maybe a better idea would be for you to archive your pyadtpulse, and i'll archive my hass-adtpulse. i'll just make changes in your hass-adtpulse from now on. This way nothing needs to be changed in hacs. Currently, I make my changes in my hass-adtpulse, then have to merge it into yours, then make a release there. Would be much simpler for me to just make branches and merges in your hass-adtpulse.

rlippmann commented 6 months ago

Ok, i've archived my hass-adtpulse, and I'm just making commits in your repo.

I'm doing all the pyadtpulse in my own repo, so if you want to archive yours, go ahead.

rlippmann commented 4 months ago

Hey Ryan,

I'm moving, so I won't have any hardware to test this anymore. Perhaps you should find another maintainer?

rsnodgrass commented 4 months ago

Thanks Richard @rlippmann for all your contributions! Not sure what we'll do with pyadtpulse and hass-adtpulse (probably less maintenance there to be honest).

Would you be willing to at least review changes people submit?

rsnodgrass commented 4 months ago

@rlippmann Should we also merge all your pyadtpulse changes back into rsnodgrass/pyadtpulse?

rlippmann commented 4 months ago

It's Robert, not Richard, lol.

I can review changes but I won't be able to test.

I do have one bug fix and new feature (arm night) pending in pyadtpulse, but I just haven't had time to test. I'll try and get to that so it can be merged.

I've also actually reverse engineered the 2FA and controlling/querying the z-wave devices, but I just haven't gotten around to implementing it. I guess I can log those as issues and document what I've found so someone else can possibly implement it in the future.

There's also a bunch of stuff jacky liang has implemented in the homebridge plugin that might be useful to add.