Closed spencergibb closed 4 years ago
In general LGTM. However, I would add a Route
interface as we discussed that previously and than make make RoutingRSocketClient implements RSocketClient, Route
and then RoutingRSocket implements RSocket, Route
.
WDYT, @spencergibb?
Remind me what Route looks like
@spencergibb Guess it should be a simple interface like the following:
interface Router {
void encodeAddressMetadata(CompositeByteBuf metadataHolder, Consumer<Tags.Builder> tagsConsumer)
}
Oh, right. Yes. I'll do that.
I missed this part.
and then RoutingRSocket implements RSocket, Route.
Are you suggesting I wrap RSocket that also implements Route? If so, I can do a follow up for that and any other edits.
Simple usage looks like (
RoutingRSocketClient
is of course optional).