DataBuffer need to be released in BrokerFrameDecoder.decode()

rsocket-broker / rsocket-broker-client

Apache License 2.0

33 stars 8 forks source link

DataBuffer need to be released in BrokerFrameDecoder.decode() #23

Closed kevinat closed 6 months ago

kevinat commented 2 years ago

In Spring's codec manner, it seems that the dataBuffer needs to be explicitly released after it is consumed by decoder.

I do seen ResourceLeakDetector report buffer leaks in logs. When I add DataBufferUtils.release(buffer) into BrokerFrameDecoder.decode(), no leak report shows.