search

rsocket / rsocket-cpp

C++ implementation of RSocket
http://rsocket.io
Apache License 2.0
253 stars 99 forks source link

add counters #770

Closed ragansa closed 7 years ago

ragansa commented 7 years ago

Got it!

lexs commented 7 years ago

For some reason my comment is super hard to find, here it is again:

Consider making the callbacks contain more information, I actually already did this in D5147228 (see stacked diffs for usage).

ragansa commented 7 years ago

@lexs 👍 That is weird, I didn't get an email the first time either.

ragansa commented 7 years ago

@somasun We don't have a resumeCache_ for:

resumeCache_->impliedPosition() ;
resumeCache_->position() ;
resumeCache_->lastResetPosition();

Can we get to these values from somewhere?

somasun commented 7 years ago

Rerunning the tests to make sure it passes on latest code. The changes look okay otherwise.