search

rsocket / rsocket-cpp

C++ implementation of RSocket
http://rsocket.io
Apache License 2.0
253 stars 99 forks source link

Clean up the KeepAlive semantics #794

Closed somasun closed 7 years ago

somasun commented 7 years ago

Addresses https://github.com/rsocket/rsocket-cpp/issues/772

lehecka commented 7 years ago

I would suggest to make FollyKeepaliveTimer an internal class as there is no other implementation of this we ever needed. It would be created by the RSocketClient with the correct event base and passed into the RSocketStateMachine. We won't need the keepalive interface either. We can have a new parameter for the RSocketClient ctor std::milliseconds keepaliveInterval = 5

somasun commented 7 years ago

Would totally love to that. I remember at some point there was a conversation about allowing application to pass in a KeepAlive implementation, so left it there assuming it is still the case.

Will update the PR.

yschimke commented 7 years ago

Two relevant issues for cleanup

https://github.com/rsocket/rsocket-cpp/issues/603 https://github.com/rsocket/rsocket-cpp/issues/706

Close when the cleanup happens