search

rsocket / rsocket-cpp

C++ implementation of RSocket
http://rsocket.io
Apache License 2.0
253 stars 99 forks source link

Revert "remove RSocketRequster::closeSocket()" #809

Closed dymk closed 7 years ago

dymk commented 7 years ago

This reverts commit 6f28d680a2cbf14a6718c9ddf441d6cd71bdd76d.

somasun commented 7 years ago

Removing RSocketRequester::closeSocket() is something we have to do soon anyway, before it starts getting widespread usage. I assume there is a plan to remove it at some point.

dymk commented 7 years ago

Correct, it'll go away in a future PR, for now we just want to sync github

On Tue, 24 Oct 2017 at 13:52 somasun notifications@github.com wrote:

Removing RSocketRequester::closeSocket() is something we have to do soon anyway, before it starts getting widespread usage. I assume there is a plan to remove it at some point.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/rsocket/rsocket-cpp/pull/809#issuecomment-339127203, or mute the thread https://github.com/notifications/unsubscribe-auth/ABgWaKqoP0Fz4MiJ6DbG7wG1Jo7V0DaYks5svk3xgaJpZM4QE5tD .