Closed stevegury closed 6 years ago
Was it intentional keep the PATENTS file during this change?
@vinc3m1 it wasn't intentional. I'm not very familiar with the licensing world of open-source, but does the PATENTS file has anything to do with the license?
I'm also not familiar with the detailed implications, but it complicates things enough that having the file in source is limiting our ability to use it currently.
IANAL, but while the license itself doesn't reference the PATENTS file, the PATENTS file still exists when someone pulls the source code and the language in the PATENTS file doesn't indicate that it's conditionally applicable to only the BSD License. It does however contain language around patents that conflicts directly with ASLv2, so I have no idea how that would be interpreted.
Either way, seems like the easiest path here is to simply delete the PATENTS file to avoid any potential for legal ambiguity since that was the original intent anyway.
@vinc3m1 Let us verify that it's fine to delete on Monday, not expecting any problems here.
Also, curious what you're looking to use rsocket for?
Sounds good, Monday is fine, thanks! We're currently trying out some Flipper integration for debugging Litho layouts.
Awesome, thanks for looking into this. If rsocket is Apache 2 without the PATENTS file (as a number of other FB projects have shifted to recently), this would open up a pretty cool new use case for Flipper :).
It sounds like we're good but waiting for final confirmation.
All good, landing https://github.com/rsocket/rsocket-cpp/pull/874 now, should sync in an hour or so.
awesome, thanks @lexs!
Thank you @lexs for taking care of that!
In order to move the project to CNCF, we need to update the license of the library from BSD to ASLv2.
This PR only modified the license headers of every file as well as the root LICENSE file. There was no code modification other than removing any trailing whitespace.
For the record, here is the script I used: