search

rsocket / rsocket-go

rsocket-go implementation
Apache License 2.0
507 stars 46 forks source link

Implement custom mux for Websocket servers #134

Open anderspitman opened 8 months ago

anderspitman commented 8 months ago

Implement custom mux for Websocket servers

Motivation:

I need to serve other HTTP content on the same mux as the websocket used by RSocket

Modifications:

Added a function for creating a WebsocketServerTransport with a mux passed in

Result:

Nothing broken, just added another function

anderspitman commented 8 months ago

Note that I'm not sure this would be the best API for accomplishing this, but it was the easiest to get my code working. If this functionality is desired upstream I'm happy to implement it in another way pending a discussions of tradeoffs.

jjeffcaii commented 8 months ago

Thanks for the PR :-) PS: Please fix the unit tests to prevent from CI failure, thanks.