search

rsocket / rsocket-java

Java implementation of RSocket
http://rsocket.io
Apache License 2.0
2.35k stars 354 forks source link

improves BaseDuplexConnection and fixes PingClient impl #1062

Closed OlegDokuka closed 2 years ago

OlegDokuka commented 2 years ago

Signed-off-by: Oleh Dokuka odokuka@vmware.com Signed-off-by: Oleh Dokuka oleh.dokuka@icloud.com

Improves BaseDuplexConnection impl

Motivation:

the impl of BaseDuplexConnection is a bit awkward because of the previous iterative reimplementation of that class.

Modifications:

This PR makes all protected fields as final (initial goal) and rework onClose notification mechanism