rsocket / rsocket-java

Java implementation of RSocket
http://rsocket.io
Apache License 2.0
2.35k stars 354 forks source link

Adds reflection hints for native-image support 1.1.x #1073

Closed violetagg closed 2 years ago

violetagg commented 2 years ago

Motivation:

The issues below are observed when trying to test rsocket native-image support 1.

Caused by: java.lang.RuntimeException: java.lang.NoSuchFieldException: producerIndex",
    "   at io.rsocket.internal.jctools.queues.UnsafeAccess.fieldOffset(UnsafeAccess.java:92) ~[na:na]",
    "   at io.rsocket.internal.jctools.queues.BaseMpscLinkedArrayQueueProducerFields.<clinit>(BaseMpscLinkedArrayQueue.java:53) ~[rsocket:na]",
    "   ... 34 common frames omitted",
    "Caused by: java.lang.NoSuchFieldException: producerIndex",
    "   at java.lang.Class.getDeclaredField(DynamicHub.java:968) ~[rsocket:na]",
    "   at io.rsocket.internal.jctools.queues.UnsafeAccess.fieldOffset(UnsafeAccess.java:90) ~[na:na]",
    "   ... 35 common frames omitted",
  1. When a ChannelHandler is added to the Netty channel pipeline, io.netty.channel.ChannelHandlerMask#mask0 will inspect the ChannelHandler's methods for io.netty.channel.ChannelHandlerMask.Skip annotation. When there are no reflection hints, NoSuchMethodException is thrown when trying to query the methods. This will lead to methods marked as not skippable, although the program will be able to run without any problems, when all methods are marked as not skippable, one might observe performance issues.

Modifications:

Result:

No issues when testing rsocket native-image support