Throwing in SocketAcceptor.accept() doesn't send ERROR frame.

rsocket / rsocket-java

Java implementation of RSocket

http://rsocket.io

Apache License 2.0

2.36k stars 354 forks source link

Throwing in SocketAcceptor.accept() doesn't send ERROR frame. #234

Closed lexs closed 7 years ago

lexs commented 7 years ago

Throwing SetupException in the handler doesn't seem to do anything, it simple gets swallowed. Same if you receive any frame that isn't SETUP in DefaultReactiveSocketServer. It logs a netty error to the console but doesn't send any frames.

benjchristensen commented 7 years ago

I think this might be the same issue as https://github.com/ReactiveSocket/reactivesocket-java/issues/169

yschimke commented 7 years ago

It is being sent, but client still processes the close first. See https://github.com/rsocket/rsocket-java/issues/311