search

rsocket / rsocket-java

Java implementation of RSocket
http://rsocket.io
Apache License 2.0
2.36k stars 354 forks source link

upgrade codebase to reactor-core 3.1.x #304

Closed tsachev closed 7 years ago

tsachev commented 7 years ago

reactor core 3.1.0.RELEASE and reactor-netty 0.7.0.RELEASE are scheduled for release by the end of this month. I plan to update my code base to use them, but there are breaking changes in reactor-core api which does not allow me to just force the new version if I depend on rsocket too. For example Mono.then(Supplier) is gone in favor of Mono.map(Supplier) etc.

Would you consider upgrade before releasing rsocket 1.0?

yschimke commented 7 years ago

+1

That makes sense to me.

yschimke commented 7 years ago

@tsachev Is there a published RC of reactor-netty? It would be good to test the changes here before 0.7.0 is released.

tsachev commented 7 years ago

just checked with the reactor devs on their gitter. It seems that they ensured that reactor-netty 0.6.4 is compatible with the new reactor-core 3.1 too. If its not you should raise issue against reactor-netty.

yschimke commented 7 years ago

@tsachev testing the upgrade here https://github.com/rsocket/rsocket-java/pull/323

yschimke commented 7 years ago

@tsachev Release date for 3.1? "it might shift toward end of August" 😑

yschimke commented 7 years ago

https://github.com/rsocket/rsocket-java/pull/400