search

rsocket / rsocket-js

JavaScript implementation of RSocket
https://github.com/rsocket/rsocket-js
Apache License 2.0
604 stars 97 forks source link

adds composite metadata support #186

Closed OlegDokuka closed 3 years ago

OlegDokuka commented 3 years ago

Provides composite metadata support (blocked till #185 merged)

Signed-off-by: Oleh Dokuka odokuka@vmware.com

viglucci commented 3 years ago

Looks like this is a straight port of flow -> typescript from the existing implementation, so I have good confidence about its correctness. We should look at moving the tests over as well though, or at least have an example for the different metadata types. I've started that effort with a routing example: https://github.com/rsocket/rsocket-js/pull/187. We don't need to wait for more examples to merge this, but I wanted to add at least one example to exercise the APIs.

Also, as we previously discussed, we should look at improving the API for working with composite metadata, but I expect that will be accomplished with the upcoming encoder/decoder pipeline work.