search

rsocket / rsocket-js

JavaScript implementation of RSocket
https://github.com/rsocket/rsocket-js
Apache License 2.0
594 stars 97 forks source link

Optional metadata for rxjs requesters #241

Closed viglucci closed 2 years ago

viglucci commented 2 years ago

Motivation:

Addressed feedback: https://github.com/rsocket/rsocket-js/issues/158#issuecomment-1208040376

Modifications:

Allow optional metadata argument in rxjs requesters

Result:

Allows for:

const rsocket = await connector.connect();

let requestResponse = RxRequestersFactory.requestResponse(
  "Hello World",
  stringCodec,
  stringCodec
);

let stringObservable = requestResponse(rsocket);

Where previously passing new Map() would have been required.

let stringObservable = requestResponse(rsocket, new Map());