Ktor 1.5.0 - Githubissues

rsocket / rsocket-kotlin

RSocket Kotlin multi-platform implementation

http://rsocket.io

Apache License 2.0

553 stars 37 forks source link

Ktor 1.5.0 #131

Closed NikkyAI closed 3 years ago

NikkyAI commented 3 years ago

Actual Behavior

Ktor serverside does not run any code in ConnectionAcceptor

although keepalives seem to get sent regularly for a bit

Steps to Reproduce

use implementation("io.rsocket.kotlin:rsocket-transport-ktor-server:1.5.0")

Your Environment

RSocket version(s) used: 0.12.0
Other relevant libraries versions (eg. netty, ...): ktor-cio and ktor-netty: 1.5.0
Platform (eg. JVM version (javar -version) or Node version (node --version)): JVM(server), client (JS)

whyoleg commented 3 years ago

Hey, can you give some code that reproduce your issue?

yschimke commented 3 years ago

Shouldn't we just go through the upgrade procedure in rocket-kotlin first anyway? Does the sample code help much ahead of this?

NikkyAI commented 3 years ago

i pretty much copied the serverside strcture from the chat example and my clientside code currently only sends things to see if it triggers code on the server

https://gist.github.com/NikkyAI/4ea409d893b12087f569516d175c642b

yschimke commented 3 years ago

@NikkyAI These example are working in place with Ktor 1.5 which is now in master. Can you perhaps apply your changes as a PR against rocket-kotlin directly? Or a standalone main.kts script. Either way would be a lot quicker to see why it's broken.

NikkyAI commented 3 years ago

tok me a while to get it to compile and publishToMavenLocal on windows note if (!HostManager.hostIsLinux) linuxX64().disableCompilation() seems to not work.. it still throws fileNotFoundExceptions for the missing .klib

as for ktor 1.5.0 .. it seems fixed with that