search

rsocket / rsocket-rpc-java

Standard RSocket RPC Java Implementation
http://rsocket.io/
Apache License 2.0
172 stars 41 forks source link

Simplify generator plugin using JProtoc #27

Open OlegDokuka opened 5 years ago

OlegDokuka commented 5 years ago

It would make it easier to support RSocket-RPC-Java plugin if it is written in a more flexible way using a templating engine like mustache or more convenient for codegen like JavaPoet.

This will simplify writing things such as #26 #20 #24

bsideup commented 5 years ago

I guess it will also open a window for some external contributors who have no C++ knowledge and dramatically simplify the build/release process

robertroeser commented 5 years ago

I don't want to require a JVM to generate code. C++ supports mustache templates though (https://github.com/no1msd/mstch), and you re-use this in different languages like .net, javascript, etc. Switching to mustache would probably do the most to make this easier than switching a language.

OlegDokuka commented 5 years ago

Yeah, sounds good to me, will look at that

bsideup commented 5 years ago

@robertroeser but in 99% cases rsocket-rpc-java will generate java sources during a Java build, and JVM will already be available. Isn't it so?

bsideup commented 5 years ago

Also, I can't see how rsocket-rpc-java's (!) generator can be reused in different languages

ilterpehlivan commented 4 years ago

@bsideup @OlegDokuka I tried to implement an alternative Rsocket Rpc based on Salesforce Jprotoc. Additionally I also tried to simplify the API usage (similar to GRPC) by natively supporting tracing, micrometer options. I appreciate if you can take a look and give feedbacks

https://github.com/ilterpehlivan/rsocket-rpc

Thanks