rsocket / rsocket-rpc-java

Standard RSocket RPC Java Implementation
http://rsocket.io/
Apache License 2.0
172 stars 41 forks source link

fix: use log4j2 and slf4j versions that match spring-boot-starter-log4j2 2.2.1.RELEASE #52

Closed flyinprogrammer closed 4 years ago

flyinprogrammer commented 4 years ago

the issue with upgrading to slf4j > 1.7.x is that when using log4j2, it requires changing log4j-slf4j-impl over to log4j-slf4j18-impl, which isn't easy for Spring projects that want to use spring-boot-starter-log4j2 to manage their log4j2 bindings.

This change would make our code trivially simple to work with Spring again because it would bring our versions back inline with what the Spring community is expecting.

The log4j2 choice to change dependency names stems from the slf4j changes that involve migrating to using ServiceLoader and is documented in LOG4J2-2305