rsodre / FulldomeCameraForUnity

Fulldome Camera for Unity 2019
http://fulldomevjs.com/
MIT License
149 stars 15 forks source link

HDRP support #1

Closed Blindsp0t-creative closed 4 years ago

Blindsp0t-creative commented 5 years ago

Hi ! And thanks a lot for providing this addon. I'm wondering if you plan to update it to the new rendering pipeline of Unity ? I'd like to play with the visual effect graph in a dome :)

Thanks again

rsodre commented 5 years ago

Hi! This plugin is basically a camera setup, so should work with any scene. Are you having difficulties with any Unity feature?

Blindsp0t-creative commented 5 years ago

Yes. I can't get no deformation using the prefab with a "High Definition Rendering Pipeline" project.

here is a screenshot :

screenShot1

I confirm i also put the "fulldome preview" script on the mainCamera:

screenShot2
rsodre commented 5 years ago

What's your Unity version?

Blindsp0t-creative commented 5 years ago

2018.3.8f1

rsodre commented 5 years ago

Just tried with the 2018.3.3 HDRP test scene and indeed seems not to work. I'll try to find out why.

rsodre commented 5 years ago

Unfortunately that the HD Pipeline does not fire the Camera's callbacks the plugin needs to render the Fulldome image. Sounds like they will include more callbacks in the future, I'll keep an eye on it and update this issue is anything changes.

But I'm working in an alternative, hold a while...

rsodre commented 5 years ago

No luck, looks like this has to be solved so I can do this...

Blindsp0t-creative commented 5 years ago

Hm... ok, i get it. Hope this will be fixed soon!

dpentecost commented 5 years ago

Thanks - This is working great in 2018.3+ other than HDRP - using NDI or Spout to get some of that into the fulldome scene. Standing by to see if Unity helps us out on this! Any news?

ahfontaine commented 5 years ago

Hey! It seems like Unity fixed the blocking issue.

rsodre commented 5 years ago

Yes, there's been some exciting new developments! I'm downloading 2019.2 to try them out

dpentecost commented 5 years ago

Woohoo! 2019 in the dome!

Director, Technology East Village Planetarium https://girlsclub.org/programs/ http://www.girlsclub.org/programs/

@dpentecost Cell 646 704 2021

On Tue, Jul 30, 2019 at 11:08 AM Roger Sodré notifications@github.com wrote:

Yes, there's been some exciting new developments! I'm downloading 2019.2 to try them out

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rsodre/FulldomeCameraForUnity/issues/1?email_source=notifications&email_token=AAARPTHGBTFSE4ITB4CRHV3QCBKNRA5CNFSM4G2KB5J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3EJIYQ#issuecomment-516461666, or mute the thread https://github.com/notifications/unsubscribe-auth/AAARPTEICJ3ZCY4W2IN4Z2LQCBKNRANCNFSM4G2KB5JQ .

rsodre commented 5 years ago

I have made a working example with HDRP (ExampleHDRP.unity). It's at the HDRP branch.

It's based on the Unity Recorder, cleaner than the original camera callbacks, and runs on the standard renderer too. I think I'll replace the main scripts later, let's see if it works well.

On this new workflow, the main camera can be disabled, since the frame will be rendered manually and copied to the backbuffer. The Game view says "No cameras rendering", but I don't see any problem. I don't know how it will work on a compiled game, if anyone could try...

rsodre commented 5 years ago

VFX Graph support will be dealt in Issue #3

Blindsp0t-creative commented 5 years ago

Such great news here !! :))

dpentecost commented 5 years ago

Tried in both MacOS and Windows. Builds fine in the 2019.2 version, quits without building in the HDRP example. Have you tried using the HDRP version with Spout or NDI? Any tips for doing that?

dpentecost commented 5 years ago

Just got it working on Keijiro's DKVfx example, using a DepthKit recording we made - success! Thank you! This opens up a lot of new VFX stuff for the dome.

BUT the inability to build an app (which gives us true fullscreen top to bottom of the frame) prevents us from using it well in our dome, since unless we mirror a fullscreen app, Unity gives us a fullscreen window in play mode. Window bars show up in the dome. Any ideas?

rsodre commented 5 years ago

I merged into master, there's a lot of changes in the plugin structure, and some new stuff I'm working on if anybody wanna try. After pull, you can delete the old FulldomeCamera folder, since now everything is in FulldomeForUnity. I changed the main folder name exactly to force these big changes, and to welcome the new stuff in. But you'll find the FulldomeCamera inside it.

Good news: The new FulldomeCamera.cs script has a better performance on Standard renderer!

Bad news: It is quite bad on HDRP. Let's find out why and fix it :)

rsodre commented 5 years ago

@dpentecost , I still did not try the Metal Syphon or NDI. And I'm allergic to Windows, hope will never need to get close to Spout.

I don't know how they will react to the changes, that should be the next step.

rsodre commented 4 years ago

Current master branch is compatible with HDRP.

dpentecost commented 4 years ago

Thanks! I’m allergic to Windows also! Our dome is closed for now but again, thanks for the great work. I will try on my macbook and see your changes.

Dave

On Thu, Aug 1, 2019 at 9:33 PM Roger Sodré notifications@github.com wrote:

@dpentecost https://github.com/dpentecost , I still did not try the Metal Syphon or NDI. And since I'm allergic to Windows, I hope to never to get close to Spout.

I don't know how they will react to the changes, that should be the next step.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rsodre/FulldomeCameraForUnity/issues/1?email_source=notifications&email_token=AAARPTD4WK6H3UQQ6E6FN4DQCOFHDA5CNFSM4G2KB5J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3MKGMQ#issuecomment-517514034, or mute the thread https://github.com/notifications/unsubscribe-auth/AAARPTC3Z7US4ML5TWT6QE3QCOFHDANCNFSM4G2KB5JQ .

--

@dpentecost Cell 646 704 2021