Can enhance the Example or Change the example to avoid potential Syntax Warning.

[ravichandraveeramachaneni]

In one of the example where is is used instead of == we are getting a potential Syntax Warning. This might be confusing sometimes. So we can enhance the example of why it happens or we can simply change that to use == instead.

Exact location : Generator & Comprehensions Section -> Reading Comprehension Exercise Solution -> Translating a For-Loop (Below screenshot from website):

So the above code mentioned produces below Warning (screenshot from my system):

Instead we can use == instead of is operator to have more cleaner interpretation (screenshot from my system):

Please let me know if this makes sense and also if there is an opportunity I would like to submit a PR for this and in future few more additions.

Thanks in Advance.

[rsokl]

Thanks for pointing this out! I would be happy to have this PR :)

[rsokl]

Oh, and I should be more specific - the example should be using == instead of is

[ravichandraveeramachaneni]

Thanks Ryan for the opportunity. I will be submitting the PR soon. However the guidelines on the git repo says that I need to be added as a contributor to make the change. Could you please add me as a contributor to the project.

My email Id : vrc0503@gmail.com

Thanks in Advance.

Regards, Ravi Chandra Veeramachaneni

On Thu, Aug 13, 2020 at 12:25 PM Ryan Soklaski notifications@github.com wrote:

Oh, and I should be more specific - the example should be using == instead of is

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rsokl/Learning_Python/issues/159#issuecomment-673666337, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADQ7G7IKMSN2WJY6DH4NXCTSAQ42RANCNFSM4P5NBHOA .

[rsokl]

Hi @RaviChandraVeeramachaneni - I need to update those guidelines. The preferred method is for you to fork the repo and make a PR from your fork.

I apologize for the confusion / inconvenience

[ravichandraveeramachaneni]

Thanks Ryan for the clarification.

I did that and made a PR (https://github.com/rsokl/Learning_Python/pull/160 ).

Could you let me know some guidelines on how to become a potential contributor to the project and make it on to the contributor / reviewer list.

Thanks in Advance.

Regards, Ravi Chandra Veeramachaneni

On Fri, Aug 14, 2020 at 8:06 AM Ryan Soklaski notifications@github.com wrote:

Hi @RaviChandraVeeramachaneni https://github.com/RaviChandraVeeramachaneni - I need to update those guidelines. The preferred method is for you to fork the repo https://docs.github.com/en/github/getting-started-with-github/fork-a-repo and make a PR from your fork.

I apologize for the confusion / inconvenience

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rsokl/Learning_Python/issues/159#issuecomment-674119526, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADQ7G7LXI3F7Q5H4NRYZMIDSAVHI5ANCNFSM4P5NBHOA .

[rsokl]

Thanks for the PR @RaviChandraVeeramachaneni

I don't have formal guidelines - if you make several contributions to PLYMI, I would happily add you as a contributor :)

[rsokl]

closed by #160