rsokl / Learning_Python

Source material for Python Like You Mean it
https://www.pythonlikeyoumeanit.com/
Other
168 stars 54 forks source link

Basic Indexing #35

Closed rsokl closed 6 years ago

rsokl commented 6 years ago

Basic Indexing needs proofreading, and code-blocks need verification for correctness.

On branch numpy_indexing

davidmascharka commented 6 years ago

Few comments (again, no line numbers because diffs on json are gross):

Reading comprehension: Ellipsis

I don't know what this question is asking. You "axis entry-0 of axis-0, the last entry of axis-$N-1$, slicing along all intermediate dimensions" but I have no idea what that means. I assume that's access entry-0, but I'm not sure where the last entry comes in.

rsokl commented 6 years ago

@davidmascharka this is the entire review, right?

davidmascharka commented 6 years ago

Yep, everything else looked good to me.

rsokl commented 6 years ago

These were awesome. Super easy to find/replace all the fixes!