Closed rsokl closed 6 years ago
Few comments (again, no line numbers because diffs on json are gross):
"Indexing into and slicing along the dimensions of an array is known as -> "are known as"
"provided a comprehensive rundown the use of" -> "rundown on the use of"
"Using a Tuple as a N-dimensional Index" -> "as an N-dimensional index"
"every time we index into a an array" -> get rid of the extra 'a'
I.e. x[i, j, k]
is equivalent" -> That is, x[i, j, k]
is" because capitalized I is weird and an abbreviation at the beginning of a sentence is odd.
"Given a N-dimensional array, x
" -> an N-dimensional
I don't know what this question is asking. You "axis entry-0 of axis-0, the last entry of axis-$N-1$, slicing along all intermediate dimensions" but I have no idea what that means. I assume that's access entry-0, but I'm not sure where the last entry comes in.
"which of the following indexing schemes perform basic indexing." -> make it a question
There are two hanging Jupyter code cells that I assume were for scratch. Delete those.
"creates a distinct array, and assigns the variable subarray
to that new array." -> assigns that new array to the variable subarray
.
"Which of the following create views x
? That is" -> "create views of x
"
"versus performing operations that produces an array" -> produce an array
"Assigning a
to a new array simply changes..." -> "Assigning a new array to a
simply changes"
"Assign row-0, colum-0 with the value" -> "Assign row-0, column-0 the value" (get rid of 'with')
Same for row-0, column-2 below that
"Recall from our discussion of basic mathematic expressions in Python" -> "mathematical expressions"
I.e. the assignment expression x = x + 5
-> For example, the assignment...
"arrays update the underyling data reference by that" -> "arrays update the underlying data referenced by that" (spell underlying correctly and change reference to referenced)
"Benefits and Risks to Autgmenting Data" -> Benefits and Risks of
"This will affect any arras that are views" -> arrays that are views
@davidmascharka this is the entire review, right?
Yep, everything else looked good to me.
These were awesome. Super easy to find/replace all the fixes!
Basic Indexing needs proofreading, and code-blocks need verification for correctness.
On branch numpy_indexing