rsp4jack / PianoFromAbove

GNU General Public License v3.0
1 stars 0 forks source link

Enhancement / option request #1

Open Keeper1st opened 2 years ago

Keeper1st commented 2 years ago

Thank you for providing an already compiled viz branch! There is an option I (and I'm sure many others with player pianos) would like to see. That would be to make all the notes the same size and distance apart when removing the piano view, to create an appearance like an actual player piano roll. In other words, instead of white notes being fat and black notes being thin (and B+C looking the same as C+D even though they're different intervals), all notes should be the same width and each harmonic interval is the same. So if you went up a chromatic scale you'd see a smooth line of notes, and a major triad would look the same no matter which note is the root, for example.

Even better would be if the notes played at the middle of the screen, as a piano roll does, instead of at the bottom.

For reference, here is a picture of a player piano's tracker bar. You see how all the notes are the same size, width and distance apart (and how the notes would play in the middle of the view as they pass down from the top to the spool on the bottom). https://anamazingmachine.files.wordpress.com/2013/02/img_0955.jpg

Having the falling notes look like a piano roll would be awesome for playing the thousands of MIDI files out there that are optical scans of actual historic paper rolls. The existing falling notes display is "wrong". I'm no coder (can't even figure out how to compile it from source) so I can only hope someone can make such a variation. It certainly would become the go-to application for player piano enthusiasts!

rsp4jack commented 2 years ago

This is a good feature! But I will not keep developing this repo. You can open this issue on another fork, or choose another player, for example, arduano/Kiva or arduano/Zenith. They are prefect (maybe), and developing well (maybe, too). :)

rsp4jack commented 2 years ago

Your features seem like implemented in arduano/Zenith.

Keeper1st commented 2 years ago

It does have the evenly spaced notes, but lacks a good interface; it is set up for loading one file, then re-opening a load dialog every time you want to play another. The great thing about PFA is that it gives a list of over 20000 piano roll scan MIDI files (across several different folders which PFA collects from) that I can browse through and double-click to play on my piano with ease.