rspace-os / rspace-web

This the main repository for RSpace: rspace-web. Check https://github.com/rspace-os/rspace-web/blob/main/DevDocs/DeveloperNotes/GettingStarted/GettingStarted.md for setup instructions.
https://github.com/rspace-os/rspace-web/wiki
GNU Affero General Public License v3.0
15 stars 3 forks source link

RSDEV-243 Have help icon in top right corner open Lighthouse #37

Closed rlamacraft closed 4 months ago

rlamacraft commented 4 months ago

This change makes the help button in the header of the new Gallery page open the Lighthouse-driven help popup that we use throughout the product.

My intention is that as more of the ELN is reactified this will become the standard way of accessing help as the current mechanism is inconsistent: the floating action button doesn't work on mobile and has to be hidden/moved when opening dialogs, and Inventory has a button in the sidebar which wont work on pages that don't need a sidebar.

https://github.com/rspace-os/rspace-web/assets/8805923/f21112de-098f-4ef0-9edd-57869c961961

Note that like in Inventory, the button is disabled until all of the third-party scripts have been loaded. Ordinarily, I don't like disabled buttons but the loading of this functionality seems to be very robust and pretty quick so the additional complexity of providing a fallback doesn't seem worth it.