rspace-os / rspace-web

This the main repository for RSpace: rspace-web. Check https://github.com/rspace-os/rspace-web/blob/main/DevDocs/DeveloperNotes/GettingStarted/GettingStarted.md for setup instructions.
https://github.com/rspace-os/rspace-web/wiki
GNU Affero General Public License v3.0
12 stars 3 forks source link

Rsdev 240 pdf page numbers #65

Closed rs-fraser closed 1 month ago

rs-fraser commented 1 month ago

This PR fixes the page numbering where the user has selected not to restart page numbering for each doc in a multi-doc or notebook export, by passing the existing length of the pdf doc into the pdf writer i.e for a new doc or when page numbering should restart each doc, the length is 0, otherwise it's the length of the existing doc.

Also rename the config property pageName to restartPageNumberingPerDoc throughout the front and back-end code, as pageName was very confusing.

And finally reduced the logging level for printing the pdf html input to debug since that's probably not something we need to log every time we export pdf as it could be very long.

rs-nicof commented 1 month ago

The code looks good to me!