rspace-os / rspace-web

This the main repository for RSpace: rspace-web. Check https://github.com/rspace-os/rspace-web/blob/main/DevDocs/DeveloperNotes/GettingStarted/GettingStarted.md for setup instructions.
https://github.com/rspace-os/rspace-web/wiki
GNU Affero General Public License v3.0
12 stars 3 forks source link

RSDEV-271: Integration with Digital Commons Data #84

Closed rs-nicof closed 2 weeks ago

rs-nicof commented 1 month ago

✅ Tested successfully on AWS ✅

AWS Test Evidence:

https://github.com/user-attachments/assets/d771eb13-1b93-4d34-81e7-a89078f22607

rs-nicof commented 3 weeks ago

Code looks good. Left a couple of comments.

I'm not 100% about the database column changes. Looking at other changesets where there are column modifications they run in the run context only. I think those modifications to column size should also be added to the hibernate entity in rspace-core-model. Maybe you know more than me about it though? It's quite confusing.

Hey @rs-fraser yes I had too do the changes becasue the token we are saving is actually longer than anyone else ever saved. It was generating an error while inserting: Data is too long That's why we had to increase the column size for those fields, and that needs to be done in PROD as well