Closed rs-nicof closed 2 weeks ago
Code looks good. Left a couple of comments.
I'm not 100% about the database column changes. Looking at other changesets where there are column modifications they run in the
run
context only. I think those modifications to column size should also be added to the hibernate entity inrspace-core-model
. Maybe you know more than me about it though? It's quite confusing.
Hey @rs-fraser
yes I had too do the changes becasue the token we are saving is actually longer than anyone else ever saved.
It was generating an error while inserting: Data is too long
That's why we had to increase the column size for those fields, and that needs to be done in PROD as well
✅ Tested successfully on AWS ✅
origin/rsdev-272-digital-commons-ui
origin/RSDEV-221-ALTOGETHER
https://rsdev-221-altogether-4.researchspace.com
intohttps://dcd-test.researchspace.com
AWS Test Evidence:
https://github.com/user-attachments/assets/d771eb13-1b93-4d34-81e7-a89078f22607