search

rspace-os / rspace-web

This the main repository for RSpace: rspace-web. Check https://github.com/rspace-os/rspace-web/blob/main/DevDocs/DeveloperNotes/GettingStarted/GettingStarted.md for setup instructions.
https://github.com/rspace-os/rspace-web/wiki
GNU Affero General Public License v3.0
14 stars 3 forks source link

RSDEV-326 Update existing tests and add new tests covering time validation for sample fields #88

Closed rs-fraser closed 2 months ago

rs-fraser commented 2 months ago

This PR uses the new "time" type from rspace-core-model so that we can validate times are in the correct format for custom template fields in inventory samples., and adds some mvc tests around that validation.

This PR updates existing tests now that the complexSampleTemplate used in many tests has a "time" field added, which previously was the only type of sample field missing from that template.

Also added some tests around the validation of time fields. Validation has been added in the related rspace-web PR: https://github.com/rspace-os/rspace-core-model/pull/7/files

rs-nicof commented 2 months ago

It looks good to me, I'ìve added just a minor comment