rspamd / rspamd.com

rspamd.com website.
https://rspamd.com
Creative Commons Attribution Share Alike 4.0 International
26 stars 125 forks source link

Clarify CORS header usage for neighbours list #773

Closed moisseev closed 1 month ago

moisseev commented 1 month ago
moisseev commented 1 month ago

@vstakhov From a security perspective, is it acceptable to always allow any origin in the CORS policy?

Currently, we conditionally add the Access-Control-Allow-Origin: * header based on the presence of multiple servers in the neighbours list.

https://github.com/rspamd/rspamd/blob/7a94c375be320b2897277cbbf9fb6a73d9c44f3c/src/controller.c#L4031-L4034

However, if we always include this header, we could achieve the following benefits:

Are there any security concerns or implications we should consider if we decide to always allow any origin?