search

rspec / rspec-core

RSpec runner and formatters
http://rspec.info
MIT License
1.23k stars 765 forks source link

Update Cucumber #2877

Closed mvz closed 3 years ago

mvz commented 3 years ago

Cucumber 3.2 is the last version that combines the following two properties:

This pull requests fixes the errors when running with Cucumber 2.x and up by improving the handler for the @ruby-2-7 tag so it uses Cucumber's standard support for skipping scenarios.

Sibling PRs:

mvz commented 3 years ago

Not to overload the 4.0 release, I thought of doing this after.

Do you mind to hold off for a while? We've just two PRs left in Core, and add deprecation messages all over repos for the functionality we've changed/removed. I think it will take roughly a month.

Sure, I can wait until after the 4.0 release.

pirj commented 3 years ago

Updated from 4-0-dev (rr dev dependency was bumped to 3.0). Moved dev dependencies to Gemfile from gemspec. Updated Cucumber further to 7.0.

pirj commented 3 years ago

JRuby failure is unrelated - bisect spec failure.

JonRowe commented 3 years ago

Can we not still run the older cucumber on the older rubies?

pirj commented 3 years ago

I've removed my changes to build scripts. Cucumber > 4 < 8 installs and runs just fine across all versions that we test on CI.

pirj commented 3 years ago

@mvz Thank you!