rspec / rspec-core

RSpec runner and formatters

http://rspec.info

MIT License

1.23k stars 765 forks source link

Extend reserved name check #2886

Closed ghost closed 3 years ago

ghost commented 3 years ago

Description

Fixes https://github.com/rspec/rspec-rails/issues/2478 to_s is now also viewed as a reserved name and thus may not be used. This also extends the name check to check against strings rather than just symbols.

pirj commented 3 years ago

1.8.7/1.9.2 CI failures are apparently due to ~https://github.com/rubygems/rubygems/issues/4549~ https://github.com/rubygems/rubygems/issues/4228

JonRowe commented 3 years ago

Can you rebase this? The build was updated with a ruby gems fix which means most legacy rubies should run now

pirj commented 3 years ago

Still red due to RubyGems.

JonRowe commented 3 years ago

Er apparently I hadn't merged those PRs that mostly fixed CI, my apologies, please rebase from latest main and try again 😹

JonRowe commented 3 years ago

Thanks, I'm pretty confident the remaining failures are existing build issues.