Closed zinovyev closed 3 years ago
:wave: we would need a test indicating how this can occur
wave we would need a test indicating how this can occur
@JonRowe sure! I've added a test for this case.
Perfect, thank you. Would you like to add a Changelog entry?
@pirj Thank you! Should I add a Changelog entry manually? Sorry I'm not completely aware of the process. I just read that in development docs:
No changelog entry is necessary (we'll add it as part of the merge process!)
Do I only need to provide a change log message or am I also supposed to add it to the CHANGELOG.md file? I would call it something like: "Prevent ExceptionPresenter failure when handling an error with a nil backtrace"
No changelog entry is necessary (we'll add it as part of the merge process!)
Oh, sorry to bother. It slipped my mind. :+1:
Thank you guys for your reviews and for being so helpful! Do you think that we can merge it now? It looks like I don't have the permission to do it by myself. Or will it just be merged automatically in some time?
I'll handle this later in the day.
Thanks for your contribution!
Currently
backtrace
of an exception is checked by theempty?
method. But it sometimes occur that the Exception class will returnnil
for backtrace: