search

rspec / rspec-core

RSpec runner and formatters
http://rspec.info
MIT License
1.23k stars 765 forks source link

Fix cucumber issues blocking ruby-head #2937

Closed petergoldstein closed 2 years ago

petergoldstein commented 2 years ago

This PR gets CI to green against ruby-head. It does so by:

  1. Loosening the cucumber version restrictions such that a ruby-head compatible version
  2. Making the tag syntax logic dynamic, based on the Ruby version
  3. Removing Fixnum from the described_class spec. (Also added a spec for the outer case)
  4. Renaming a when condition to avoid a string escape behavior that varies between cucumber versions.

cc: @JonRowe

petergoldstein commented 2 years ago

I'm seeing failures on Ruby 2.3 (Windows) and JRuby 1.7, but those appear to be pre-existing problems.

There's a doc check failure, but rspec and cucumber run cleanly on ruby-head with these changes.

petergoldstein commented 2 years ago

The doc check failure is an issue in yard. There is a fix - https://github.com/lsegal/yard/commit/7dca12cc53532ad1308113b2b09d51815897851f - but it's not in a released gem yet.

JonRowe commented 2 years ago

@petergoldstein thanks so much for this, it's been merged in #2950